Enzyme: bump version and mark models as working [test] #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
May 8, 2024
|
@ToucheSir mind giving it a re-review. I now expect the only non-supported test is convtranspose, which should be fixed by FluxML/NNlib.jl#582. Nevertheless enabling that test can be in a subsequent PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2439 +/- ##
===========================================
+ Coverage 46.37% 74.10% +27.72%
===========================================
Files 32 32
Lines 1876 1923 +47
===========================================
+ Hits 870 1425 +555
+ Misses 1006 498 -508 ☔ View full report in Codecov by Sentry. |
CarloLucibello
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue from GRU was fixed on Enzyme main recently (EnzymeAD/Enzyme.jl#1261).
Seeing if they now pass CI here (conv untested, but let's see what happens).
Bumping Enzyme to later version